GLTFLoader: Add before/afterRoot hookpoints #21207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
0b5vr
pushed a commit
to 0b5vr/three-ts-types
that referenced
this pull request
Feb 10, 2021
joshuaellis
pushed a commit
to three-types/three-ts-types
that referenced
this pull request
Feb 11, 2021
* feature (GLTFLoader): Add beforeRoot and afterRoot to GLTFLoaderPlugin See: mrdoob/three.js#21207 * fix (GLTFLoader): add missing methods of GLTFParser * test: add gltfloader-plugin.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: #20789
Description
This PR adds invokeAll
before/afterRoothookpoints.beforeRoot()hook is called before starting the entre glTF but after for parsing glTF binary to JSON. The main use case would be for hacking glTF definition. (I remember some devs requested it.) And handlers for extensions under the root may need it.afterRoot(result)hook is called after generating all Three.js objects. The main use case would be handling extensions under the root and/or apply some changes to the generated Three.js objects. My material variants extension handler plugin needs this hook point.