Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material: Move flatShading to supported materials. #21200

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 4, 2021

Related issue: Fixed #7130.

Description

flatShading is no longer a property of Material. The only materials supporting flat shading are:

  • MeshPhongMaterial
  • MeshStandardMaterial
  • MeshPhysicalMaterial
  • MeshNormalMaterial
  • MeshMatcapMaterial

It looks horrible when using it when MeshToonMaterial so I have left it out.

@mrdoob mrdoob added this to the r126 milestone Feb 4, 2021
@mrdoob mrdoob merged commit 1ac550c into mrdoob:dev Feb 4, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlatShading on MeshLambertMaterial
2 participants