Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial material configuration in example #21191

Merged
merged 1 commit into from
Feb 2, 2021
Merged

Conversation

schmijos
Copy link
Contributor

@schmijos schmijos commented Feb 2, 2021

This is a small fix for the envmap example. No related Github issue.

Description

The example for envmaps swapped the initial parameters and uses the inexistent roguhness-member of params. This example works as expected only as long as metallness is intialized with 0.0.

This contribution is funded by Renuo AG.

@schmijos schmijos changed the title Fix initial material configuration Fix initial material configuration in example Feb 2, 2021
@Mugen87 Mugen87 changed the base branch from master to dev February 2, 2021 12:35
@Mugen87 Mugen87 added this to the r126 milestone Feb 2, 2021
@mrdoob mrdoob merged commit 341f708 into mrdoob:dev Feb 2, 2021
@mrdoob
Copy link
Owner

mrdoob commented Feb 2, 2021

Thanks!

@schmijos schmijos deleted the patch-1 branch February 2, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants