Examples: Regenerate RGBM textures. #21173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very nice! |
|
Thanks! |
|
I suggest to recommend users who want to convert to RGBM the above fiddle. If more users request a RGBM converter, we can still use the code to create a new example. |
|
I was/am going to turn the fiddle into a little webapp 🤓 |
|
Even better 😊 ! I've added a small update so things are properly disposed. |
|
It still remains to set the files' color profiles correctly (somehow). It is currently set to |
|
I've searched the API of |
|
Oh well, it is not critical. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #21145
Description
This PR regenerates RGBM textures in the repo with this code: https://jsfiddle.net/xf5oy3hd/1/
When comparing the examples, you can see less artifacts and a better brightness. This is especially noticeable in
webgl_loader_texture_rgbm.