-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGPU: All UBOs and varys is generate by nodes #21170
Conversation
Sidenote: The PR currently breaks |
Fixed! 5922e92 |
Next steps I have here ... You guys have something in mind what I should prioritize?
|
An initial version of However, I would not start with introducing a custom shading language for node material. Let's assume for now I would suggest to demonstrate |
@mrdoob Do you have a preference here? #21170 (comment) I just finished |
Merging this so you can move on. We can rename |
|
||
class CameraNode extends Node { | ||
|
||
static POSITION = 'position'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sidenote: The default JavaScript parser of ESLint (Espree) does currently not support class fields syntax. Hence, the linter reports a parsing error:
Unexpected token =
The only way to fix this right now is to use a different parser like @babel/eslint-parser
. However, this will require an additional dev dependency and an enhancement of the eslintConfig
section in package.json
.
@mrdoob Unless we don't start using class fields in the core, I recommend to do nothing for now. This issue should hopefully be resolved when class fields are not experimental anymore.
UBOs
andvarys
is generate bynodes
GLPositionNode
,ModelNode
,CameraNode
,Matrix3Node
,Matrix4Node
,VaryNode
,PositionNode
Related: #20421 (comment)