Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color: Fix ReDoS in setStyle #21143

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Color: Fix ReDoS in setStyle #21143

merged 4 commits into from
Jan 25, 2021
+4 −4

Conversation

yetingli
Copy link
Contributor

Related issue: #21132

Description

Fix ReDoS in Color's setStyle.

mrdoob
mrdoob reviewed Jan 25, 2021
View reviewed changes
src/math/Color.js Outdated Show resolved Hide resolved
@mrdoob mrdoob mentioned this pull request Jan 25, 2021
Closed
@mrdoob mrdoob added this to the r125 milestone Jan 25, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 25, 2021

Seems like the right solution 👍

@mrdoob mrdoob merged commit 67e8854 into mrdoob:dev Jan 25, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 25, 2021

Thanks!

@appakz appakz mentioned this pull request Dec 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrdoob mrdoob mrdoob left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r125
Development

Successfully merging this pull request may close these issues.
2 participants
@yetingli @mrdoob