KTX2Loader: Improve parsing and transcoding process. #21137
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #21094 and #21131.
Simplifies and improves KTX2Loader in several ways:
The last item is not required, but is small (~1.5kb / 3kb, with and without tree-shaking) and should make it easier to add support for more features of the KTX format — which are not needed for glTF, and therefore not implemented yet — in the future.
After this change, the
msc_basis_transcoder
dependency is removed, and a warning is printed if the dependency's global variable is found. Users should update to usesetTranscoderPath( ... )
, the same as with BasisTextureLoader. This may need to be noted in the changelog.