Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #21032

Merged
merged 1 commit into from
Jan 8, 2021
Merged

Update README.md #21032

merged 1 commit into from
Jan 8, 2021

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jan 8, 2021

Related issue: #21018

Description

Use BoxBufferGeometry instead of BoxGeometry.

Use `BoxBufferGeometry` instead of `BoxGeometry`.
@mrdoob mrdoob added this to the r125 milestone Jan 8, 2021
@mrdoob mrdoob merged commit dcca2b7 into dev Jan 8, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 8, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jan 8, 2021

It's ugly indeed 😕

@Mugen87 Mugen87 deleted the Mugen87-patch-1 branch January 8, 2021 19:54
@mrdoob
Copy link
Owner

mrdoob commented Jan 8, 2021

How about we rename all the geometry generators to BoxGeometry, CircleGeometry, etc

But we leave BufferGeometry and co as it is?

And then we add export { BoxGeometry as BoxBufferGeometry }, etc in Three.Legacy.js?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 9, 2021

I think it's better to keep the class names like BoxGeometry intact (and not deprecate them) if you have the intention to rename BufferGeometry to Geometry at some point.

BTW: EdgesGeometry and WireframeGeometry are already derived from BufferGeometry.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jan 9, 2021

I've made a PR with an alternative approach 👍 . Seeing code makes it easier to compare with what we have in dev now.

@mrdoob
Copy link
Owner

mrdoob commented Jan 9, 2021

I think it's better to keep the class names like BoxGeometry intact (and not deprecate them) if you have the intention to rename BufferGeometry to Geometry at some point.

👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants