[TypeScript] Add loadAsync typing #21001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Jan 4, 2021
mrdoob
reviewed
Jan 5, 2021
| @@ -31,4 +31,6 @@ export class ObjectLoader extends Loader { | |||
| animations: AnimationClip[] | |||
| ): T; | |||
|
|
|||
| loadAsync<ObjectType extends Object3D>( url: string, onProgress?: ( event: ProgressEvent ) => void ): Promise<ObjectType>; | |||
There was a problem hiding this comment.
Should this be like this?
loadAsync<T extends Object3D>( url: string, onProgress?: ( event: ProgressEvent ) => void ): Promise<T>;There was a problem hiding this comment.
I took type declaration name from load. Should I change ObjectType to T there as well?
There was a problem hiding this comment.
No idea to be honest. I don't know much about types...
We can merged it as it is and let other people fix it if it's wrong.
|
This is a chore but... could you update the PR so the |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by user MikeJF on general discord:
Description
Right now all
loadAsyncdefault toPromise<any>. Added typing forloadAsyncin Loaders to resemble properloadtyping.