Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTX2Loader: Fix calculation of level dimensions for NPOT textures. #20888

Merged
merged 2 commits into from
Jan 9, 2021
Merged

KTX2Loader: Fix calculation of level dimensions for NPOT textures. #20888

merged 2 commits into from
Jan 9, 2021

Conversation

donmccurdy
Copy link
Collaborator

If original texture size is NPOT, sizes of mipmaps must be rounded down to the nearest integer, not up.

@mrdoob mrdoob added this to the r124 milestone Dec 14, 2020
@mrdoob mrdoob modified the milestones: r124, r125 Dec 22, 2020
@mrdoob mrdoob merged commit 03e97e7 into mrdoob:dev Jan 9, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jan 9, 2021

Thanks!

@donmccurdy donmccurdy deleted the bug-ktx2-mip-sizes branch January 9, 2021 18:46
@donmccurdy donmccurdy mentioned this pull request Jan 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeux zeux zeux left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r125
Development

Successfully merging this pull request may close these issues.
3 participants
@donmccurdy @mrdoob @zeux