-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webgl_gpgpu_birds references error #20675
Fix webgl_gpgpu_birds references error #20675
Conversation
I find this change confusing. These names are in "world space". If you look at the bird top-view. The left wing has negative values on the x, and the right wing has positive values on the x. |
Okay, I just personally use to judge the left and right from the perspective of the creature itself. |
Yes please. |
@mrdoob Restored. |
If the bird is facing the positive-z axis, then the "right wing" points in the negative-x direction in our coordinate system. @gonnavis is correct. |
Merging. The left/right issue can be changed with another PR if necessary. |
Thanks! |
1912046 😇 |
references
should be computed frombirdIndex
nottriangleIndex
.The most obvious problem of current version is the diferent colors of one bird.
Second is that
WIDTH
andtrianglesPerBird
must be one odd and one even, can't both even or both odd, otherwise will produce very messy result.By the way, also changed the left right of the wings' names by bird's self view, not camera view.