Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webgl_gpgpu_birds references error #20675

Merged
merged 5 commits into from
Apr 20, 2021

Conversation

gonnavis
Copy link
Contributor

@gonnavis gonnavis commented Nov 12, 2020

references should be computed from birdIndex not triangleIndex.

The most obvious problem of current version is the diferent colors of one bird.
Second is that WIDTH and trianglesPerBird must be one odd and one even, can't both even or both odd, otherwise will produce very messy result.

By the way, also changed the left right of the wings' names by bird's self view, not camera view.

@gonnavis gonnavis changed the title Fix webgl_gpgpu_birds index error Fix webgl_gpgpu_birds references error Nov 12, 2020
@mrdoob
Copy link
Owner

mrdoob commented Nov 12, 2020

By the way, also changed the left right of the wings' names by bird's self view, not camera view.

I find this change confusing. These names are in "world space". If you look at the bird top-view. The left wing has negative values on the x, and the right wing has positive values on the x.

@mrdoob mrdoob added this to the r123 milestone Nov 12, 2020
@gonnavis
Copy link
Contributor Author

gonnavis commented Nov 12, 2020

Okay, I just personally use to judge the left and right from the perspective of the creature itself.
Shall I roll back the change of LEFT RIGHT to let this pr purely target the modification of references?
May change the geometry to sync self space and world space later.

@mrdoob
Copy link
Owner

mrdoob commented Nov 12, 2020

Shall I roll back the change of LEFT RIGHT to let this pr purely target the modification of references?

Yes please.

@gonnavis
Copy link
Contributor Author

@mrdoob Restored.

@WestLangley
Copy link
Collaborator

If the bird is facing the positive-z axis, then the "right wing" points in the negative-x direction in our coordinate system.

@gonnavis is correct.

@mrdoob mrdoob modified the milestones: r123, r124 Nov 25, 2020
@mrdoob mrdoob modified the milestones: r124, r125 Dec 24, 2020
@mrdoob mrdoob modified the milestones: r125, r126 Jan 27, 2021
@mrdoob mrdoob modified the milestones: r126, r127 Feb 23, 2021
@mrdoob mrdoob modified the milestones: r127, r128 Mar 30, 2021
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 20, 2021

Merging. The left/right issue can be changed with another PR if necessary.

@Mugen87 Mugen87 merged commit b36ce9e into mrdoob:dev Apr 20, 2021
@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2021

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Apr 20, 2021

1912046 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants