src/textures: move to es6 classes #20009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
43 tasks
mrdoob
reviewed
Aug 17, 2020
mrdoob
reviewed
Aug 17, 2020
marcofugaro
reviewed
Aug 18, 2020
mrdoob
reviewed
Aug 19, 2020
|
conflicts resolved |
|
There seem to be linter issues on this one. |
|
Thanks for fixing the linter errors. |
|
oops. |
mrdoob
reviewed
Feb 5, 2021
This was referenced Feb 9, 2021
Mugen87
reviewed
Feb 18, 2021
Mugen87
reviewed
Feb 18, 2021
Mugen87
approved these changes
Feb 19, 2021
mrdoob
reviewed
Feb 20, 2021
Comment on lines
-62
to
+75
| this.encoding = encoding; | ||
| this.offset = new Vector2( 0, 0 ); | ||
| this.repeat = new Vector2( 1, 1 ); | ||
| this.center = new Vector2( 0, 0 ); | ||
| this.rotation = 0; | ||
|
|
||
| this.version = 0; | ||
| this.onUpdate = null; | ||
| this.matrixAutoUpdate = true; | ||
| this.matrix = new Matrix3(); | ||
|
|
||
| } | ||
| // Values of encoding !== THREE.LinearEncoding only supported on map, envMap and emissiveMap. | ||
| // | ||
| // Also changing the encoding after already used by a Material will not automatically make the Material | ||
| // update. You need to explicitly call Material.needsUpdate to trigger it to recompile. | ||
| this.encoding = encoding; | ||
|
|
||
| Texture.DEFAULT_IMAGE = undefined; | ||
| Texture.DEFAULT_MAPPING = UVMapping; | ||
| this.generateMipmaps = true; | ||
| this.premultiplyAlpha = false; | ||
| this.flipY = true; | ||
| this.unpackAlignment = 4; // valid values: 1, 2, 4, 8 (see http://www.khronos.org/opengles/sdk/docs/man/xhtml/glPixelStorei.xml) | ||
|
|
||
| Texture.prototype = Object.assign( Object.create( EventDispatcher.prototype ), { | ||
| // Values of encoding !== THREE.LinearEncoding only supported on map, envMap and emissiveMap. | ||
| // | ||
| // Also changing the encoding after already used by a Material will not automatically make the Material | ||
| // update. You need to explicitly call Material.needsUpdate to trigger it to recompile. | ||
| this.encoding = encoding !== undefined ? encoding : LinearEncoding; |
mrdoob
reviewed
Feb 20, 2021
Comment on lines
+60
to
65
| // Values of encoding !== THREE.LinearEncoding only supported on map, envMap and emissiveMap. | ||
| // | ||
| // Also changing the encoding after already used by a Material will not automatically make the Material | ||
| // update. You need to explicitly call Material.needsUpdate to trigger it to recompile. | ||
| this.encoding = encoding; | ||
|
|
There was a problem hiding this comment.
This part seems to be duplicated.
|
Some minor things. I'll merge and clean that up. |
|
Thanks! |
thank you 👍 |
|
Looks like the class properties introduced in this PR broke all examples in Safari. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.