-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Loaders to es6 classes #19985
Merged
mrdoob
merged 4 commits into
mrdoob:dev
from
DefinitelyMaybe:loaders--move-to-es6-classes
Feb 6, 2021
Merged
core: Loaders to es6 classes #19985
mrdoob
merged 4 commits into
mrdoob:dev
from
DefinitelyMaybe:loaders--move-to-es6-classes
Feb 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DefinitelyMaybe
changed the title
core: Loaders to es6 classes
Draft: core: Loaders to es6 classes
Aug 1, 2020
Closed
43 tasks
Mugen87
reviewed
Aug 2, 2020
as #19982 has been merged, I can either add example loaders to this PR or see if I can get the tests to re-run. might need to do a dummy commit but we'll see. |
DefinitelyMaybe
force-pushed
the
loaders--move-to-es6-classes
branch
from
August 15, 2020 03:12
734341e
to
e7f3d7d
Compare
DefinitelyMaybe
changed the title
Draft: core: Loaders to es6 classes
core: Loaders to es6 classes
Aug 15, 2020
removed changes to loaders which were used by any example script. |
conflicts resolved |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supported by #19982 i.e. managed to build without errors after implementing those changes.
Did run
npm test
but we will see what comes back from the automated tests. I'm feeling slightly weary of the current testing, future me problem.note:
Many loaders have the following pattern:
It doesn't look very good to me however instead of trying to tackle that within the same PR I'll follow up on this one in a future PR.