Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support scene background and environment texture in ObjectLoader and toJSON #18834

Merged
merged 11 commits into from
Jun 19, 2021
Merged

Support scene background and environment texture in ObjectLoader and toJSON #18834

merged 11 commits into from
Jun 19, 2021

Conversation

meliharvey
Copy link
Contributor

@meliharvey meliharvey commented Mar 7, 2020 •
edited by Mugen87
Loading

ObjectLoader and toJSON haven't supported scene backgrounds or environment textures.

Fixes: #18479 and #18715.

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 7, 2020 •
edited
Loading

Can you please undo all changes to both build files (build/three.js and build/three.module.js)?

Mugen87
Mugen87 reviewed Mar 7, 2020
View reviewed changes
src/core/Object3D.js Outdated Show resolved Hide resolved
Mugen87
Mugen87 reviewed Mar 7, 2020
View reviewed changes
src/core/Object3D.js Outdated Show resolved Hide resolved
Mugen87
Mugen87 reviewed Mar 7, 2020
View reviewed changes
src/core/Object3D.js Outdated Show resolved Hide resolved
Mugen87
Mugen87 reviewed Mar 7, 2020
View reviewed changes
src/loaders/ObjectLoader.js Outdated Show resolved Hide resolved
Mugen87
Mugen87 reviewed Mar 7, 2020
View reviewed changes
src/loaders/ObjectLoader.js Outdated Show resolved Hide resolved
@meliharvey meliharvey changed the title Support scene background and environment texture in OjbectLoader and toJSON Support scene background and environment texture in ObjectLoader and toJSON Mar 7, 2020
@meliharvey meliharvey marked this pull request as ready for review March 7, 2020 20:20
@meliharvey
Copy link
Contributor Author

I'm curious what's the plan for merging this PR? Thanks!

@mrdoob mrdoob added this to the r124 milestone Nov 25, 2020
@mrdoob mrdoob modified the milestones: r124, r125 Dec 24, 2020
@mrdoob mrdoob modified the milestones: r125, r126 Jan 27, 2021
@Mugen87 Mugen87 mentioned this pull request Feb 6, 2021
Closed
@mrdoob mrdoob modified the milestones: r126, r127 Feb 23, 2021
@Mugen87 Mugen87 mentioned this pull request Feb 25, 2021
Closed
@Mugen87 Mugen87 mentioned this pull request Mar 15, 2021
Closed
@mrdoob mrdoob modified the milestones: r127, r128 Mar 30, 2021
@mrdoob mrdoob modified the milestones: r128, r129 Apr 23, 2021
@mrdoob mrdoob modified the milestones: r129, r130 May 27, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 19, 2021

Sorry for the delay... 😬

@mrdoob mrdoob merged commit e9fb8d4 into mrdoob:dev Jun 19, 2021
@mrdoob
Copy link
Owner

mrdoob commented Jun 19, 2021

Thanks!

@Mugen87 Mugen87 mentioned this pull request Jun 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r130
Development

Successfully merging this pull request may close these issues.
3 participants
@meliharvey @Mugen87 @mrdoob