Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example: Fix typos in unreal bloom demo #18048

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Conversation

donmccurdy
Copy link
Collaborator

Demo: https://raw.githack.com/mrdoob/three.js/donmccurdy-bloom-typos/examples/webgl_postprocessing_unreal_bloom.html

^Might be worth putting shared #info styles in main.css later? Good to have a consistent way to add a bit of text that will be responsive on desktop and mobile.

@donmccurdy donmccurdy changed the title Update webgl_postprocessing_unreal_bloom.html Example: Fix typos in unreal bloom demo Dec 3, 2019
@Mugen87 Mugen87 added this to the r112 milestone Dec 3, 2019
@mrdoob
Copy link
Owner

mrdoob commented Dec 3, 2019

^Might be worth putting shared #info styles in main.css later? Good to have a consistent way to add a bit of text that will be responsive on desktop and mobile.

It seems more fitting to have that information in the source of UnrealBloomPass rather than in the demo.

@mrdoob
Copy link
Owner

mrdoob commented Dec 3, 2019

We can leave that for another PR.

@mrdoob mrdoob merged commit e9f31ad into master Dec 3, 2019
@mrdoob
Copy link
Owner

mrdoob commented Dec 3, 2019

Thanks!

@mrdoob mrdoob deleted the donmccurdy-bloom-typos branch December 3, 2019 23:30
@mrdoob
Copy link
Owner

mrdoob commented Dec 3, 2019

Ops, this targeted master. Merged master into dev.

@donmccurdy
Copy link
Collaborator Author

Ah sorry! Thought I could do this change in the GitHub UI instead of locally, must have missed that dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants