Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOD: Add hysteresis option. #14566

Merged
merged 4 commits into from
Nov 4, 2022
Merged

LOD: Add hysteresis option. #14566

merged 4 commits into from
Nov 4, 2022

Conversation

donmccurdy
Copy link
Collaborator

Fixes #14565.

@mrdoob mrdoob modified the milestones: r95, r96 Jul 27, 2018
@donmccurdy
Copy link
Collaborator Author

Closing per #14565 (comment), but glad to reopen if others have a use for this.

@donmccurdy donmccurdy closed this Aug 6, 2018
@Mugen87 Mugen87 removed this from the r96 milestone Aug 6, 2018
@mrdoob
Copy link
Owner

mrdoob commented Aug 6, 2018

Lets keep this open 😊

@mrdoob mrdoob reopened this Aug 6, 2018
@mrdoob mrdoob added this to the r96 milestone Aug 6, 2018
@mrdoob mrdoob modified the milestones: r96, r97 Aug 29, 2018
@mrdoob mrdoob modified the milestones: r97, r98 Sep 25, 2018
@mrdoob mrdoob modified the milestones: r98, r99 Oct 31, 2018
@mrdoob mrdoob modified the milestones: r99, r100 Nov 29, 2018
@mrdoob mrdoob modified the milestones: r100, r101 Dec 31, 2018
@mrdoob mrdoob modified the milestones: r101, r102 Jan 31, 2019
@mrdoob mrdoob modified the milestones: r102, r103 Feb 28, 2019
@mrdoob mrdoob modified the milestones: r103, r104 Mar 27, 2019
@mrdoob mrdoob modified the milestones: r104, r105 Apr 24, 2019
@mrdoob mrdoob modified the milestones: r105, r106 May 30, 2019
@mrdoob mrdoob removed this from the r106 milestone Jun 26, 2019
@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 24, 2022

Is it possible to rebase and merge this PR? 😇

I've recently used the exact same code to avoid the LOD-flickering mentioned in #14565.

@mrdoob mrdoob modified the milestones: r139, r140 Mar 24, 2022
@donmccurdy donmccurdy force-pushed the feat-lod-hysteresis branch from 1aad26f to faa3c16 Compare March 25, 2022 04:04
@donmccurdy
Copy link
Collaborator Author

✅ Rebased!

frankenstein-its-alive

@mrdoob mrdoob modified the milestones: r140, r141 Apr 30, 2022
@mrdoob mrdoob modified the milestones: r141, r142 May 26, 2022
@mrdoob mrdoob modified the milestones: r142, r143 Jun 29, 2022
@mrdoob mrdoob modified the milestones: r143, r144 Jul 28, 2022
@mrdoob mrdoob modified the milestones: r144, r145 Aug 31, 2022
@mrdoob mrdoob modified the milestones: r145, r146 Sep 29, 2022
@mrdoob mrdoob modified the milestones: r146, r147 Oct 27, 2022
Mugen87
Mugen87 reviewed Oct 30, 2022
View reviewed changes
src/objects/LOD.js Outdated Show resolved Hide resolved
@Mugen87 Mugen87 merged commit 4337937 into mrdoob:dev Nov 4, 2022
@donmccurdy donmccurdy deleted the feat-lod-hysteresis branch November 4, 2022 12:43
@0b5vr 0b5vr mentioned this pull request Dec 7, 2022
Closed
12 tasks
0b5vr added a commit to three-types/three-ts-types that referenced this pull request Dec 19, 2022
@0b5vr
feat (LOD): Add hysteresis option
f8c52f3 
mrdoob/three.js#14566
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

@gsimone gsimone gsimone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r147
Development

Successfully merging this pull request may close these issues.

LOD: Consider adding hysteresis option.
4 participants
@donmccurdy @mrdoob @Mugen87 @gsimone