Skip to content

Commit

Permalink
Three.Legacy: Added scene.autoUpdate warning.
Browse files Browse the repository at this point in the history
  • Loading branch information
mrdoob committed Aug 23, 2022
1 parent 757dadf commit c6e9386
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions src/Three.Legacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { TetrahedronGeometry } from './geometries/TetrahedronGeometry.js';
import { TorusGeometry } from './geometries/TorusGeometry.js';
import { TorusKnotGeometry } from './geometries/TorusKnotGeometry.js';
import { TubeGeometry } from './geometries/TubeGeometry.js';
import { Scene } from './scenes/Scene.js';

// r134, d65e0af06644fe5a84a6fc0e372f4318f95a04c0

Expand Down Expand Up @@ -317,4 +318,24 @@ export class TubeBufferGeometry extends TubeGeometry {

}

// r144

Object.defineProperty( Scene.prototype, 'autoUpdate', {

get() {

console.warn( 'THREE.Scene: autoUpdate has been renamed matrixWorldAutoUpdate.' );
return this.matrixWorldAutoUpdate;

},

set( value ) {

console.warn( 'THREE.Scene: autoUpdate has been renamed matrixWorldAutoUpdate.' );
this.matrixWorldAutoUpdate = value;

}

} );


3 comments on commit c6e9386

@LeviPesin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we have decided to keep sucb properties in-class, no?

@mrdoob
Copy link
Owner Author

@mrdoob mrdoob commented on c6e9386 Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, was not sure if we resolved that.

Happy to move it to the class!

@mrdoob
Copy link
Owner Author

@mrdoob mrdoob commented on c6e9386 Aug 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! 399eb20

Please sign in to comment.