Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing campaign fixes #58

Merged
merged 19 commits into from
Jun 22, 2020
Merged

Fuzzing campaign fixes #58

merged 19 commits into from
Jun 22, 2020

Conversation

mratsim
Copy link
Owner

@mratsim mratsim commented Jun 20, 2020

This PR

Reactivating the squaring which would reenable a significant 20% performance improvement is tracked in #68.
Note that the error is an off-by-one in the least significant bit in the Montgomery representation.
It happens in both the generic squaring algorithm and the fast squaring from Consensys.

I suspect a carry is missing from the literature, though the literature on Montgomery squaring is pretty scarce.

@mratsim mratsim changed the title [WIP] Fix sqrt bugs [WIP] Fuzzing campaign fixes Jun 21, 2020
@mratsim mratsim merged commit ec76ac5 into master Jun 22, 2020
@mratsim mratsim deleted the fix-sqrt-bugs branch June 29, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment