fix(browser): prevent error stream.push() after EOF

[sanduluca]

check if the stream is still open and writable before pushing data.

Also I was wondering if a Event Listener Cleanup should be made ? I dont see any removeEventListener to prevent any further callbacks from firing after closure:

    socket.removeEventListener('close', onClose);
    socket.removeEventListener('error', onError);
    socket.removeEventListener('message', onMessage);
    socket.removeEventListener('open', onOpen);

Fixes #1914

[sanduluca]

Hmm 🤔
nodejs/node#445

[robertsLando]

@sanduluca Thanks for your PR!

About the event listeners, if you are speaking about Websocket event listeners yes it could make sense to remove them on destroy anyway once the socket is destroyed it should be garbage collected and should not create any problem but 🤷🏼‍♂️

[robertsLando]

Hmm 🤔 nodejs/node#445

It's almost 10 years old now 😆 Anyway I wonder so if there is a better way to handle this? Does this change solve your issue?

[robertsLando]

cc @mcollina could you give a look at this please?

[robertsLando]

@mcollina ping