This repository has been archived by the owner on Jan 9, 2024. It is now read-only.
feat: You can now sign web extensions without IDs #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar303
force-pushed
the
no-id
branch
3 times, most recently
from
00ec1f1 to
7864996
Compare
kumar303
force-pushed
the
no-id
branch
2 times, most recently
from
a961e61 to
63b738d
Compare
| @@ -59,20 +59,32 @@ export class Client { | |||
| * | |||
| * @param {Object} conf | |||
| * - `xpiPath` Path to xpi file. | |||
| * - `guid` add-on GUID, aka the ID in install.rdf. | |||
| * - `guid` add-on GUID, aka the ID in install.rdf. This can be empty. | |||
There was a problem hiding this comment.
@kumar303 how about "(optional)" instead of "This can be empty."?
|
@kumar303 this looks already good to me. |
|
I updated the README with some notes about dealing with IDs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for mozilla/web-ext#178