Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting to CompilerEnvirons to allow the 'use strict' directive… #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

peterj99a
Copy link

… to be ignored.

The directive implementation changed between 1.7.1 and 1.7.2, for backward compatibility the user may want to disable it.

… to be ignored.

The directive implementation changed between 1.7.1 and 1.7.2, for backward compatibility the user may want to disable it.
@gbrail
Copy link
Collaborator

gbrail commented Nov 10, 2017

We also talked off-line about addressing the thing that changed in 1.7.7.2 (supporting use strict inside a function body) and making that dependent on the language level, so that it won't break compatibility for anyone on an older language level, as it does now. Do you think that fixing it that way would be more appropriate?

Also, we often fix these sorts of things by adding a feature flag to Context. If we do want to support this feature, do you think that makes more sense?

@p-bakker
Copy link
Collaborator

@gbrail as this PR is 7 years old, is related to a backwards compatibility issue in quite an old Rhino version and there's been no activity on this, shall we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants