-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft for reading configuration from config files #1722
base: master
Are you sure you want to change the base?
Conversation
I think that this approach makes sense in that it lets configuration come from the environment, system properties, file, or classpath. I think that's a good thing and that we should follow this pattern. For actually checking the setting of various flags, however, I think that the config class should parse all this input and set boolean (or enum) values that can be checked directly, rather than relying on a hash lookup. I think that can give us two advantages:
|
I think I can implement this next week or so... |
If you're looking for the kinds of debug flags I'd like to potentially replace with a real debugging mechanism, I would look at these:
And as for feature flags, the first one IMO should be for the reflect and proxy support that's currently languishing in a PR by @rbri |
Unfortunately, I didn't have as much time as I thought, but I wanted to update the draft before Christmas of how I want to do it now. The idea is, to check all sources (classpath, configfile, system-properties, env - the last one wins) for the settings and parse them immediately in the correct datatype. When a variable is bound to the property @gbrail I hope, this goes in the right direction... Unfortunately (or fortunately) I won't be able to continue until next year due to vacation. :) |
This could be a first draft for #1720