Use to primitive for plus operation and date (taken from #1611 done by @tonygermano) #1685
Conversation
|
From my point of view this is ready to be squash-merged... what do you think? |
| throw ScriptRuntime.typeErrorById( | ||
| "msg.invalid.toprimitive.hint", ScriptRuntime.toString(arg0)); | ||
| } | ||
| ; |
There was a problem hiding this comment.
Minor, but do you know why there is a semicolon here?
| prototype/Symbol.toPrimitive/hint-string-first-valid.js | ||
| prototype/Symbol.toPrimitive/length.js | ||
| prototype/Symbol.toPrimitive/name.js | ||
| prototype/Symbol.toPrimitive/called-as-function.js |
There was a problem hiding this comment.
It looks like we made a bunch of new tests pass, but we also made a test that previously passed fail, from what it looks like. Do you know why this appears to be failing now?
There was a problem hiding this comment.
Have seen this alteady but there was no time for that. Will check
There was a problem hiding this comment.
called-as-function.js seems to be a more general problem we have the same with the toJSON prototype.
This function passes in the past because a type error was expected (and there was no toPrimitiveSupport).
Will have another look at this and maybe open an issue for that, but in gerneral it is nothing introduced by this one.
|
Yes, it looks good, but I have two minor points -- can you check them out? Thanks! |
|
OK -- thanks for looking at the test and removing that huge problem with the semicolon ;-) |
This is another carve out from #1661.
Please squash this on merge.