-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Move LiveConnect / Java interop classes to own jar #1655
Draft
rPraml
wants to merge
16
commits into
mozilla:master
Choose a base branch
from
FOCONIS:lc-try-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume you know you can run Rhino without Java Interop enabled, no? |
Roland is working on documenting the specifics about that -- this reduces
the risk that someone can escape into arbitrary Java code.
…On Thu, Sep 26, 2024 at 8:41 AM Paul Bakker ***@***.***> wrote:
I assume you know you can run Rhino without Java Interop enabled, no?
—
Reply to this email directly, view it on GitHub
<#1655 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD7I22SNQU7MT3XRT6H6ULZYQTL3AVCNFSM6AAAAABO5COYXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZXGMZDIOJSHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
further input follows. Can someone change this PR to draft? I do not have the permission (or do not find the "convert to draft" button 😆 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I want to discuss, if it is a good or bad idea, to move the LiveConnect classes (NativeJavaXXX etc.) to a own package, so that it may be separated to a own jar(
rhino-liveconnect.jar
)I'm aware that this requires to modify some APIs and will introduce a breaking change.
So far I have started to do a proof of concept, but before I put more energy into it, I wanted to ask if this is even desired.
The advantage is clearly, that the whole liveconnect thing, which most of the reflection and everything sits in an own jar. If the jar is not on the classpath, you cannot interact with java classes from your script.
The idea is to route everything over the wrapFactory (no wrapFactory = no liveConnect)
This PR shows the proof of concept and is still a draft. You may also see, that a lot of methods from ScriptRuntime etc. has to be made public. So I do not know if this is intended, but maybe we can adapt some of the ideas (especially, the idea, when the wrapFactory is null, that every attempt will fail in an exception)