Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.8 RC1: Dynamic Scopes vs. initStandardObjects (NativeSymbol) #377

Closed
raimi opened this issue Jan 5, 2018 · 4 comments
Closed

1.7.8 RC1: Dynamic Scopes vs. initStandardObjects (NativeSymbol) #377

raimi opened this issue Jan 5, 2018 · 4 comments

Comments

@raimi
Copy link

raimi commented Jan 5, 2018

As discussed in https://groups.google.com/forum/#!topic/mozilla-rhino/ez3kr8-o0oI : there is an issue in my specific way of using dynamic scopes initStandardObjects, namely NativeSymbol.

I prepared a testcase.

@raimi
Copy link
Author

raimi commented Jan 5, 2018

To be clear: passing sealed = false to initStandardObjects(ScriptableObject scope, boolean sealed) makes the problem go away.

@gbrail
Copy link
Collaborator

gbrail commented Jan 16, 2018

Here's a PR for this with a test case:

#381

Can you try it out? I'd like to merge it before we do Rhino 1.7.8 later this week.

@raimi
Copy link
Author

raimi commented Jan 17, 2018

Good news: This fixes both the test-case and our application. Perhaps you can accept both my and your PR? Doesn't hurt to have more tests :)

gbrail pushed a commit that referenced this issue Jan 22, 2018
@gbrail
Copy link
Collaborator

gbrail commented Jan 22, 2018

Fixed this one in #378.

@gbrail gbrail closed this as completed Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants