Remove legacy code related to base64 encoded secret. Fixes #89 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akatsoulas r? |
johngian
changed the title
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 94.71% 95.06% +0.34%
==========================================
Files 6 6
Lines 246 243 -3
==========================================
- Hits 233 231 -2
+ Misses 13 12 -1
Continue to review full report at Codecov.
|
akatsoulas
approved these changes
Jun 6, 2017
mozilla_django_oidc/auth.py
Outdated
| secret = self.OIDC_RP_CLIENT_SECRET | ||
| if import_from_settings('OIDC_RP_CLIENT_SECRET_ENCODED', False): | ||
| secret = base64.urlsafe_b64decode(self.OIDC_RP_CLIENT_SECRET) | ||
|
|
||
| # Verify the token | ||
| verified_token = jws.verify(token, secret, algorithms=['HS256']) |
There was a problem hiding this comment.
nit: You can directly use here self.OIDC_RP_CLIENT_SECRET since secret it's not used anywhere else now that you are removing the base64 stuff so that we can remove another line.
johngian
force-pushed
the
remove-legacy-base64
branch
from
3a41273 to
e0e5ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.