Upgrade sentry and enable tracing #15778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
reviewed
Sep 12, 2023
chenba
reviewed
Sep 12, 2023
| @@ -49,7 +50,7 @@ export class GoogleMapsService { | |||
| scope.setContext('googleMapsService', { | |||
| address, | |||
| }); | |||
| Sentry.captureMessage(error.message, Sentry.Severity.Error); | |||
| Sentry.captureMessage(error.message, 'error' as SeverityLevel); | |||
There was a problem hiding this comment.
Sentry removed the severity enum in the new version?
There was a problem hiding this comment.
They did! I was also surprised by this. See release notes here.
chenba
approved these changes
Sep 12, 2023
dschom
force-pushed
the
enable-sentry-perf
branch
2 times, most recently
from
d90ba74 to
948c477
Compare
dschom
force-pushed
the
enable-sentry-perf
branch
from
948c477 to
850acfa
Compare
dschom
force-pushed
the
enable-sentry-perf
branch
from
850acfa to
6e062cc
Compare
Because: - We want to enable performance monitoring - We want to upgrade sentry This Commit: - Upgrades sentry to the latest version - Enables tracing by setting the tracesSampleRate to 1 by default. - Tracing can be altered / disabled by setting SENTRY_TRACES_SAMPLE_RATE to a value between 0 and 1.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-8219, FXA-8103
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Other information (Optional)
Note that currently only the front ends have instrumented cleanly out of the box. We will need to file a follow up ticket for getting tracing (which drives performance monitoring) working on the server side. It's important to know that auto instrumentation is not supported for hapi (see this issue), and that it seems like nestjs is in a similar state.
Interestingly enough Sentry supports otel and it appears to be the recommended approach in some cases. Since we support otel instrumentation on the server side already, we will look into taking this approach. A short experiment with auth server was promising, but definitely deserves its own PR, since it requires upgrading otel and some other tweaks as well.
For now, we will apply these changes, so we can get some client side performance metrics for content server despite knowing the tracing capabilities will be incomplete for server side requests.