Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minumum supported Rust version to cargo.toml #424

Closed
tublitzed opened this issue Feb 11, 2020 · 2 comments · Fixed by #475
Closed

Add minumum supported Rust version to cargo.toml #424

tublitzed opened this issue Feb 11, 2020 · 2 comments · Fixed by #475
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.

Comments

@tublitzed
Copy link
Contributor

Looks like it's now supported.

Probably makes sense to do this to avoid future issues with versions that are too old.
@tublitzed tublitzed self-assigned this Mar 9, 2020
@tublitzed tublitzed added the 1 Estimate - xs - This is a trivial change with clearly defined parameters. label Mar 9, 2020
tublitzed added a commit that referenced this issue Mar 10, 2020
@tublitzed
chore: add minumum supported rust version
9740221 
closes #424
@tublitzed tublitzed mentioned this issue Mar 10, 2020
Merged
@pjenvey
Copy link
Member

pjenvey commented Mar 11, 2020

Reopening because I just noticed the RFC hasn't been implemented yet: rust-lang/rust#65262

So #475 emits a harmless warning:

$ cargo build
warning: unused manifest key: package.rust

Let's revert it and just add the minimum version to the README for now

@pjenvey pjenvey reopened this Mar 11, 2020
@tublitzed
Copy link
Contributor Author

Ah shoot, thanks @pjenvey! Closing this now and will re-open if/when implemented.

@tublitzed tublitzed mentioned this issue Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add minumum supported rust version mozilla-services/syncstorage-rs
2 participants
@pjenvey @tublitzed