Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor [Menu] Remove possibly spamming logs for Menu #23753

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor [Menu] Remove possibly spamming logs for Menu #23753

wants to merge 1 commit into from

Conversation

adudenamedruby
Copy link
Contributor

📜 Tickets

no tickets for this work.

💡 Description

Removes logs that are possibly spammy for the Main Menu.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@adudenamedruby adudenamedruby requested a review from a team as a code owner December 13, 2024 17:36
@adudenamedruby
Copy link
Contributor Author

@mergify backport release/v134

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

backport release/v134

🟠 Waiting for conditions to match

  • merged [📌 backport requirement]

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.61%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 31.99

File Coverage
BrowserCoordinator.swift 73.05% ✅
MainMenuCoordinator.swift 87.76% ✅

Generated by 🚫 Danger Swift against 44943bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cramsden Cramsden Cramsden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adudenamedruby @mobiletest-ci-bot @Cramsden