Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FXIOS-10597 - When rotating the device, text entered into the toolbar disappears. (backport #23370) #23744

Open
wants to merge 1 commit into
base: release/v134
Choose a base branch
from
Open

Bugfix FXIOS-10597 - When rotating the device, text entered into the toolbar disappears. (backport #23370) #23744

wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 13, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

  • We have two BrowserAddressToolbar instances for regular and compact sizes. When rotating the device, these instances switch between each other, causing the text entered in one instance to be lost.
  • This PR preserves the text in the urlTextField using redux.

Video

video.mov

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)
This is an automatic backport of pull request #23370 done by [Mergify](https://mergify.com).

@PARAIPAN9 @mergify
Bugfix FXIOS-10597 - When rotating the device, text entered into the …
bfddd3f 
…toolbar disappears. (#23370)

* Add persistentURLText static property

* Update text in urlTextField using redux

* Add didSetSearchTerm toolbar action and write unit test

(cherry picked from commit e3a47e5)
@mergify mergify bot requested a review from a team as a code owner December 13, 2024 13:08
@mergify mergify bot requested review from issammani and removed request for a team December 13, 2024 13:08
@mergify mergify bot mentioned this pull request Dec 13, 2024
Merged
6 tasks
@PARAIPAN9 PARAIPAN9 requested review from PARAIPAN9 and removed request for issammani December 13, 2024 13:10
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.69%
📖 Edited 6 files
📖 Created 0 files

Client.app: Coverage: 31.56

File Coverage
AddressToolbarContainerModel.swift 34.43% ⚠️
AddressBarState.swift 90.4% ✅
AddressToolbarContainer.swift 0.0% ⚠️
ToolbarState.swift 9.21% ⚠️
ToolbarAction.swift 75.86% ✅

Generated by 🚫 Danger Swift against bfddd3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PARAIPAN9 PARAIPAN9 PARAIPAN9 approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mobiletest-ci-bot @PARAIPAN9