-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix certain arguments not being correctly escaped or causing batch syntax error #83
Conversation
21431c5
to
73d4bed
Compare
ae1a178
to
d3c3a5a
Compare
This PR is blocked until a bug in npm is solved regarding executables in |
@satazor: I'm curious, what's the NPM bug? Do you have a link to their issue tracker? |
I can't disclose the bug because it's also a security vulnerability. I can email you though. |
Sure, I'm [email protected]. Thanks. |
Any updates to this PR? I've traced a webpack bundling warning in my electron app back to this library attempting to require spawn-sync. This PR by removing node v0.10 support, that should correct the build warning. |
d3c3a5a
to
c34de84
Compare
I've updated the PR. I will merge this once it becomes green and release 6.0.0. |
c34de84
to
5c829bc
Compare
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
======================================
Coverage 98.8% 98.8%
======================================
Files 7 7
Lines 167 167
Branches 35 35
======================================
Hits 165 165
Misses 2 2
Continue to review full report at Codecov.
|
f575053
to
2381dfe
Compare
…ch syntax error More specifically: - Fix a bug that made it impossible to escape an argument that contained quotes followed by `>` or other special chars, e.g.: `"foo|bar"`, fixes #82 - Fix a bug were a command containing `%x%` would be replaced with the contents of the `x` environment variable, fixes #51 This was resolved by using `^` to escape all meta chars. Additionally, double escaping was necessary for cmd-shim files located in `node_modules./bin/`. Also, this commit was a major overhaul: - Upgrade tooling - Upgrate project to es6 (node v4) - Fix commands as posix unix relatixe paths not working correctly - Fix `options` argument being mutated - Improve compliance with node's ENOENT errors - Improve detection of node's shell option support - Migrate project to moxystudio BREAKING CHANGE: remove support for older nodejs versions, only node >= 4 is supported Fixes #82, #51
2381dfe
to
900cf10
Compare
@cspotcode I've fixed the issue regarding the npm cmd-shim by double-escaping the windows shell meta chars. I've tested this exhaustively and it's working correctly! |
More specifically:
>
or other special chars, e.g.:"foo|bar"
, fixes Bad escaping when an argument has quotes followed by a pipe #82%x%
would be replaced with the contents of thex
environment variable, fixes Fixes bug: unable to spawn .bat with %<environment variable>% in name #51This was resolved by using
^
to escape all meta chars.Additionally, double escaping was necessary for cmd-shim files located in
node_modules./bin/
.Also, this commit was a major overhaul:
options
argument being mutatedBREAKING CHANGE: remove support for older nodejs versions, only node >= 4 is supported