fix: detect path key based on correct environment #133
+22
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
Windows machine with
Path
environment key containing the PATH. An environment is passed in where the PATH is namedPATH
.cross-spawn
will pass an undefinedpath
intowhich
, which makeswhich
fall back toprocess.env.Path
.This is troublesome if the first hit in
options.env.PATH
is not an executable file but the first hit inprocess.env.Path
is an executable file.cross-spawn
doesn't realise it needs to wrap the command withcmd.exe
.We're running into this in yarnpkg/berry#1377, where we prepend the PATH with a folder containing
node.cmd
butcross-spawn
detectsC:\Program Files\nodejs\node.exe
instead.