Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PER-155] - Packet and credential processing performance scripts #1926

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

akhilmoogi
Copy link

The PR contains:

  1. Packet_Credential_Processing_Test_Script.jmx
  2. support-files - reg_id.txt
  3. readme file

@nihallakshmankonchady
Copy link

@akhilmoogi ,
Please update following changes for the script.

  1. Load RID From File --> Change reg_id to regID
  2. Regproc DB Configuration --> Change variable name regprc_connection ---> regProcConnection
  3. Credential DB Configuration --> Change variable name credential_connection ---> credentialConnection
  4. Auth Token Generation (Setup) --> Sampler names should end with Endpoint
  5. Execution Threadgroup Name should end with (Execution)
  6. Samplers in Execution threadgroup should end with Query
  7. Rename JSR223 postprocessor with appropriate names, so we can identify whats actions are performed inside.
  8. Update variable names in postprocessor in meaningful names.
  9. Update ReadMe file.

@nihallakshmankonchady
Copy link

nihallakshmankonchady commented Nov 27, 2024

@akhilmoogi
Script end:

  • Regproc DB Configuration--> Database connection configuration--> Database url --> rename regproc_dbName to regprocDbName
  • Credential DB Configuration--> Database connection configuration--> Database url --> rename credential_dbName to credentialDbName
  • Capture And Convert The Response Time(All Results Threadgroup) --> provide meaningful variable names
  • QueryReg Proc Secure Zone Notification --> QueryReg Proc Secure Zone Query
  • Are we not creating separate report for query and scenario?

Readme File:

  • It is better to add Setup and Preparation scenarios names under list of scenarios
  • Are we not adding Design process in readme file?

@nihallakshmankonchady
Copy link

@akhilmoogi ,
Please find my review
Packet_Creator_Script

  • Load Context Details From File --> contextDetails.csv to context_details.csv
  • Load Document Path From File --> documentPath.txt to document_path.txt
  • Auth Token Generation (Setup)--> update the sampler name to Generate Regproc Auth Token Endpoint, Generate Resident Auth Token Endpoint, Generate Regproc Authentication Using User Id Endpoint
  • Load Regproc Auth Token From File, Load Resident Auth Token From File remove "." after ${runTimeFilePath}
  • No need of scenario level report
  • Sync And Upload Registration Packet (Preparation) --> ramp up time is empty

Packet credential processing:

  • Script is not updated as per previous review comments

ReadMe file

  • Jmeter sscripts --> Jmeter scripts
  • befor --> before
  • Test Setup for Script 1: spcifying to specifying
  • Description of thread groups from script 1: Need to remove extra spaces in the context
  • Test Setup for Script 2: remove ` before "the reponse times between each stage"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants