Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-659/ES-661: fix truncated icons and popover content #11

Closed
wants to merge 142 commits into from
Closed

ES-659/ES-661: fix truncated icons and popover content #11

wants to merge 142 commits into from

Conversation

bunsy-0900
Copy link
Contributor

@bunsy-0900 bunsy-0900 commented Jan 16, 2024 •
edited
Loading

Issue

Mobile: info icon symbol and texts with icon are getting truncated for "Full Name in Khmer" and for "Password" text field in Setup Account screen

Mobile(iphone-7) : info icon is getting disappeared on re-opening the screen from recent apps in account set up screen

Solution

Conditionally render the popup based on the screen size of the device.

  • show the popup to the right for tablet and big-screen devices
  • show the popup to the bottom for smartphones.

@bunsy-0900 bunsy-0900 changed the title Draft: ES-659: fix truncated popover content ES-659: fix truncated icons and popover content Jan 17, 2024
@bunsy-0900 bunsy-0900 changed the title ES-659: fix truncated icons and popover content ES-659/ES-661: fix truncated icons and popover content Jan 17, 2024
aranaravi
aranaravi requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@aranaravi aranaravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setupResponseInterceptor is not used i guess, can you please remove the import statement

rathanak-0080 and others added 27 commits January 17, 2024 12:00
@rathanak-0080 @bunsy-0900
Initial commit
e875b73 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
add signup-ui
8fb14b5 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
ES-407-sign-up-ui-khmer-language-bundle-creation
4a02e49 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
update translation
235c5d1 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
initial sign up ui commit
4b2509f 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
feat: add common error pages
f37aafa 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
feat: add account setup page to the steps
7fd3761 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
feat: add success registration page
856c1d5 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
Code code base from esignet to esignet-signup
c0f843e 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@aranaravi @bunsy-0900
Signup page css and design changes
836dc26 
Signed-off-by: Aravindhan Alagesan <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@aranaravi @bunsy-0900
Added the new line as per the comment
500a079 
Signed-off-by: Aravindhan Alagesan <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
chore: refactor code and fix user interface
4d0df8d 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix phone user interface
5d4ce4a 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix otp step user interface
06947ed 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix phone status creation step UI
b95f19b 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix sign up page layout
3f83f33 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix button and steps ui
49932bd 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix phone and otp steps ui
78d9bb1 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: disable username input of account setup step
a29f842 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
chore: add .env.example and update README
cbbe4c4 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix pass and confirm pass validation
3a17d10 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix verify challenge endpoint call
d5ce82b 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: remove deprecated file
b86c1ee 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
chore: add eof
ed6deb7 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: move nav bar and footer to app
cfeb927 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
chore: delete use client
7ea0895 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsyy @bunsy-0900
fix: fix layout
c0c060a 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
mengleang-0090 and others added 29 commits January 17, 2024 12:00
@mengleang-0090 @mengleang-ngoun @bunsy-0900
ES-473 and ES-474 (#73)
64ab4c5 
* config spring security and create endpoint to get csrf token

* add unit-test for new endpoint

* fix coding style

* audit trasaction

* fix code smells

* resolve comment

* remove PropertySource from AuditTransactionRequest.java

* add endline in some file

* replace url with mosip.api.internal.url in properties file

* add auditTransactionHelper to everyendpoint

* fix bug

* add auditTransactionHelper with GENERATE_CHALLENGE SUCCESS

* fix bug with DTO

* update test case

* resolve comment

* rename auditEvent

* remove covert request DTO

* remove audit transaction

* rename some var

* add audit transaction in reset password endpoint

* move set response time inside try catch

---------

Co-authored-by: Mengleang <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@rathanak-0080 @bunsy-0900
Update translation text (#75)
5467da6 
Co-authored-by: Sreang Rathanak <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@rathanak-0080 @bunsy-0900
Fix base 64 bug (#77)
987861f 
Co-authored-by: Sreang Rathanak <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@rathanak-0080 @bunsy-0900
update docker file (#78)
f731615 
Co-authored-by: Sreang Rathanak <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
ES-635: fix verify button enabled unexpectedly (#76)
add8ea3 
* fix: fix otp verify btn is enabled unexpected

* fix: fix unexpected otp verification button enable in reset password

Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@mengleang-0090 @mengleang-ngoun @bunsy-0900
ES-522 (#72)
8a13cf6 
* create service controller dto for reset password endpoint

* complete multi auth challenge verify

* fix unit test

* fix unit test

* fix unit test

* complate unit test

* multi-auth challenge verify

* fix styling

* rename addIdentity res and req DTO to Identity

* add switch case in postVerifiedChallenge

* create constant for acticated indentity

* create controller and service

* move reset-password endpoint to SignUpController

* resolve conflict with develop commit d136cb4

* Revert "resolve conflict with develop commit d136cb4"

This reverts commit 8f482a66292f2bc2e4637280936fa27c33d6d1f6.

* resolve test case error after resolve conflict

* fix cannot reset password

* fix json convert in identity

* add unit test on reset password

* update route path

* add more test case in resetPassword controller

* rewrite challenge validator and add handler from id repo service

* add end line in lombok.config

* resolve config and add more ErrorConstants

* remove ignore test case

* remove used ErrorConstants

* add otp size

* update cors and csrf

* add test case and add transaction to registered

* add sms notification template

* send sms notification when successfully reset password

* remove check Challenge OTP length

* update test case name

---------

Co-authored-by: Mengleang <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@ase-101 @bunsy-0900
ES-414 (#79)
478327d 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@rathanak-0080 @bunsy-0900
ES-414: Update inline text and error popup (#80)
09c7bc0 
* Update inline text and error popup

* Update inline text and error popup

---------

Co-authored-by: Sreang Rathanak <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@ase-101 @bunsy-0900
ES-391 (#82)
47d6a0d 
Signed-off-by: ase-101 <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@ase-101 @bunsy-0900
ES-391 (#83)
d051ab1 
Signed-off-by: ase-101 <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@ase-101 @bunsy-0900
ES-391 fixed validation issue (#84)
2b45c46 
Signed-off-by: ase-101 <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
ES-632: getting validation message even before providing input (#85)
9cc28d8 
* fix(phone): fix validation message

* fix: fix the way to show validation message

* fix: disable required to fix the onBlur validation

* fix(AccountSetup): fix validation login in the AccountSetup page

* fix(UserInfo): fix validation logic of the UserInfo page

* fix: disable button on continue

* fix(ResetPassword): fix validation logic of the ResetPassword page

* fix(validation): fix confirm password validation logic

* fix: fix validation message logic

* fix: fix button state

Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
chore: fix validation message (#81)
1e66f65 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@rathanak-0080 @bunsy-0900
Add term and condition content (#86)
a825e04 
Co-authored-by: Sreang Rathanak <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@gk-4VII @bunsy-0900
[ES-624] Fixed the issue of updated language in login screen is not r…
414202f 
…eflecting in signup screen when navigating from login screen to signup screen. (#87)

Signed-off-by: GurukiranP <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: add custom waiting duration (#88)
eceeeab 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: show invalid transaction as a popup when resending otp (#89)
008a7bf 
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: disallow leading and trailing whitespaces when filling the full …
23f9392 
…name (#90)

Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
ES-664: password mask/unmask icon is overlapped in specific browser v…
f3d4024 
…iew (#91)

* fix: separate the eye icon from the input

* fix: fix validation error input border

Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@lengheang-0116 @bunsy-0900
ES-658: Fix issue where the back arrow in the signup card overlaps wi…
18bbe6a 
…th text in mobile responsive (#93)

* ES-658: Fix issue where the back arrow in the signup card overlaps with text in mobile responsive

* Remove duplicate px

Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@rathanak-0080 @bunsy-0900
UI not match to user story (#92)
194c260 
Signed-off-by: Sreang Rathanak <[email protected]>
Co-authored-by: Sreang Rathanak <[email protected]>
Signed-off-by: Sreang Rathanak <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@ase-101 @bunsy-0900
ES-498
54c3beb 
Signed-off-by: ase-101 <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@ase-101 @bunsy-0900
ES-498
91bce3f 
Signed-off-by: ase-101 <[email protected]>
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: add missing imports
ab8ec56 
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: fix overflow popup content
1b4093d 
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: resize info icon on small screen
ec22c7a 
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: fix truncated icons
5601012 
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: add margin to icon label
eb29d86 
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900
fix: add default width and height to label icon
0e0fe64 
Signed-off-by: bunsy-0900 <[email protected]>
@bunsy-0900 bunsy-0900 closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranaravi aranaravi aranaravi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@bunsy-0900 @aranaravi @rathanak-0080 @bunsyy @gk-4VII @panharith-0118 @ase-101 @mengleang-0090 @Mohanraj209 @lengheang-0116