remove try-except

mosaicml · Oct 11, 2024 · 71d3c6d · 71d3c6d
1 parent c558a13
commit 71d3c6d
Showing 1 changed file with 16 additions and 18 deletions.
diff --git a/tests/callbacks/test_callbacks.py b/tests/callbacks/test_callbacks.py
@@ -97,13 +97,12 @@ def maybe_skip_callback_test(callback_class: type):
 def test_build_callback(callback_name: str, callback_class: type):
     maybe_skip_callback_test(callback_class)
     get_default_kwargs(callback_class)
-    try:
-        callback = build_callback(
-            callback_name,
-            kwargs=get_default_kwargs(callback_class),
-        )
-    except ImportError:
-        pytest.skip(f'Skipping {callback_name} because of missing import.')
+
+    callback = build_callback(
+        callback_name,
+        kwargs=get_default_kwargs(callback_class),
+    )
+
     assert isinstance(callback, callback_class)
     assert isinstance(callback, Callback)
 
@@ -115,16 +114,15 @@ def test_build_callback(callback_name: str, callback_class: type):
 def test_build_callback_with_config(callback_name: str, callback_class: type):
     maybe_skip_callback_test(callback_class)
     get_default_kwargs(callback_class)
-    try:
-        callback = build_callback(
-            callback_name,
-            kwargs=get_default_kwargs(callback_class),
-            train_config={
-                'save_folder': 'test',
-                'save_interval': '1ba',
-            },
-        )
-    except ImportError:
-        pytest.skip(f'Skipping {callback_name} because of missing import.')
+
+    callback = build_callback(
+        callback_name,
+        kwargs=get_default_kwargs(callback_class),
+        train_config={
+            'save_folder': 'test',
+            'save_interval': '1ba',
+        },
+    )
+
     assert isinstance(callback, callback_class)
     assert isinstance(callback, CallbackWithConfig)