Add better error handling for non-rank 0 during Monolithic Checkpoint Loading #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j316chuck
force-pushed
the
chuck/add_better_error_handling
branch
from
21e5588 to
2905366
Compare
j316chuck
force-pushed
the
chuck/add_better_error_handling
branch
from
029f5b8 to
edaf21c
Compare
mvpatel2000
reviewed
Oct 14, 2024
mvpatel2000
reviewed
Oct 14, 2024
j316chuck
force-pushed
the
chuck/add_better_error_handling
branch
from
95624dd to
add1fa1
Compare
j316chuck
force-pushed
the
chuck/add_better_error_handling
branch
from
add1fa1 to
915251b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previously, all rank's 1 - N would return a File not Found Error when local rank 0 failed to download the monolithic checkpoint resulting in a confusing debugging experience.
This new logic changes the exception on non global rank 0's to raise an Error that points users to look at the local rank 0 for better debugging experience.
What issue(s) does this change relate to?
https://databricks.atlassian.net/browse/GRT-3308
Tests
EXTRA_ARGS='-vv -k test_load_incorrect_path' WORLD_SIZE=2 make test-dist-gpu