Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Legacy Checkpointing #3631

Merged
merged 9 commits into from
Oct 1, 2024
Merged

Remove Legacy Checkpointing #3631

merged 9 commits into from
Oct 1, 2024

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Sep 23, 2024

What does this PR do?

Remove legacy checkpointing. This codepath is incredibly brittle and buggy and has caused numerous issues. As it was only available for a brief period, we do not think it will affect end-users. We will provide an upgrade script to users who do have these checkpoints.

@mvpatel2000 mvpatel2000 changed the title [WIP] Remove Legacy Checkpointing Remove Legacy Checkpointing Sep 23, 2024
@mvpatel2000 mvpatel2000 requested review from bigning, dakinggg and j316chuck and removed request for bigning September 23, 2024 21:07
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you please run the regression and daily tests against this PR before merging?

tests/trainer/test_fsdp_checkpoint.py Outdated Show resolved Hide resolved
@mvpatel2000 mvpatel2000 merged commit 2963293 into main Oct 1, 2024
34 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/remove-legacy branch October 1, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants