Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 2.4.1 test #3612

Merged
merged 2 commits into from
Sep 10, 2024
Merged

fix 2.4.1 test #3612

merged 2 commits into from
Sep 10, 2024

Conversation

bigning
Copy link
Contributor

@bigning bigning commented Sep 10, 2024 •
edited
Loading

Fix the torch 2.4.1 2-gpu tests. It missed a auto-microbatch torch patch.

@bigning bigning marked this pull request as ready for review September 10, 2024 21:57
@bigning bigning requested a review from a team September 10, 2024 22:12
mvpatel2000
mvpatel2000 approved these changes Sep 10, 2024
View reviewed changes
composer/trainer/_patch_pytorch.py Outdated Show resolved Hide resolved
@bigning bigning enabled auto-merge (squash) September 10, 2024 22:57
@bigning bigning merged commit a9cd768 into main Sep 10, 2024
14 checks passed
@bigning bigning deleted the fix2.4.1 branch September 10, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@irenedea irenedea Awaiting requested review from irenedea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigning @mvpatel2000