Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v0.24.0 + deprecations #3570

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Conversation

snarayan21
Copy link
Contributor

@snarayan21 snarayan21 commented Aug 23, 2024

What does this PR do?

Bumps to 0.24.0 and deprecates some code paths, notably passing process_group and device_mesh directly in the fsdp config object.

Dailies succeeded: https://github.com/mosaicml/composer/actions/runs/10528606007

Continuation of #3527

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@snarayan21 snarayan21 requested a review from a team as a code owner August 23, 2024 15:49
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do daily tests for sharded tensor ckpts pass? 🤔

composer/checkpoint/load.py Outdated Show resolved Hide resolved
composer/core/state.py Outdated Show resolved Hide resolved
composer/checkpoint/load.py Outdated Show resolved Hide resolved
@snarayan21 snarayan21 merged commit 020b0ef into main Aug 23, 2024
26 checks passed
@snarayan21 snarayan21 deleted the saaketh/bump_version_v0.24.0 branch August 23, 2024 18:22
@antoinebrl
Copy link
Contributor

Hello! The released was prepared in this MR but no tag was added. What would it take to complete the publication of this version?

@snarayan21
Copy link
Contributor Author

@antoinebrl We'll be releasing the new version today -- just didn't want to release over the weekend :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants