Bump aws_ofi_nccl to 1.11.0 #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snarayan21
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
lgtm.
Note: This is needed to unblock intra-node sequence parallelism. With this version bump, we are able to do all to alls in process groups of size 4 or 2 in a single node.
Previous failed run (8gpu): hf-input-tJf3NR
Successful run (8gpu): hf-input-h0sWUt
Successful run (32gpu): hf-input-XyffD0
snarayan21
requested review from
karan6181,
mvpatel2000,
dakinggg and
bandish-shah
mvpatel2000
approved these changes
Aug 22, 2024
|
More testing: Single node seq par run that works with new images: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump aws_ofi_nccl plugin to 1.11.0 latest.