Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save load path in state and pass to mosaicmllogger #3506

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

ethanma-db
Copy link
Contributor

@ethanma-db ethanma-db commented Jul 30, 2024

What does this PR do?

Goal is to provide more visibility in the run life cycle. To do this, we can indicate when a run is resumed from checkpoint or not by displaying the load path if it was resumed from a checkpoint. Corresponding mcloud PR with mcli describe changes:
https://github.com/databricks-mosaic/mcloud/pull/4338

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@ethanma-db ethanma-db marked this pull request as ready for review July 30, 2024 21:10
@ethanma-db ethanma-db requested a review from a team as a code owner July 30, 2024 21:10
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a pr description if you're ready for review

Edit: you did :)

Copy link
Contributor

@KuuCi KuuCi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! (might want to wait for daniel tho :) )

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a minor nit

composer/loggers/mosaicml_logger.py Outdated Show resolved Hide resolved
Copy link
Contributor

@b-chu b-chu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'm hesitant about adding more public attributes to state. Is there something that already exists in state that we can do a before_load and after_load check on @eracah ?

@mvpatel2000
Copy link
Contributor

Thanks for the PR! I'm hesitant about adding more public attributes to state. Is there something that already exists in state that we can do a before_load and after_load check on @eracah ?

Ethan and I discussed offline -- unfortunately i don' t think so because of the autoresume behavior... but open to ideas

@b-chu
Copy link
Contributor

b-chu commented Jul 31, 2024

No idea unfortunately. I'm not blocking so feel free to merge

@ethanma-db ethanma-db merged commit aba617d into mosaicml:dev Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants