Hsdp + MoE CI tests #3378
Merged
Hsdp + MoE CI tests #3378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 4, 2024 14:50
mvpatel2000
reviewed
Jun 21, 2024
added 4 commits
June 20, 2024 20:36
mvpatel2000
reviewed
Jun 24, 2024
added 2 commits
June 24, 2024 13:37
mvpatel2000
approved these changes
Jun 24, 2024
fix formatting Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
to mvpatel2000/composer
that referenced
this pull request
Jul 21, 2024
* fold ema fsdp state * debug * debug * more debug * keep debugging * debug * sanity check * debug * debug * use ema * debug * debug * debug * debug * debug * debug * more fix * filename test * revert test * fully parameterize * hsdp test * revert testing * typo * typo * hsdp * split off test * precommit * float to int * pyright * oom * print * rm tp * tp cfg * tp? * rm tp line * type annotation * revert * readd tp * type * world size * revert * revert monolithic cpkt + include sharded cpkt * enumerate * precommit * precommit * sharded * sync * only sync on first trainer * typo * hsdp * xfail * explicit sync * test * revert test * sync, docker issue * pre-commit * sync * pytest * xfail * rm world_size param * im so sorry pls forgive me king * the kings comments * Update tests/trainer/test_fsdp_checkpoint.py fix formatting Co-authored-by: Mihir Patel <[email protected]> * precommit --------- Co-authored-by: v-chen_data <[email protected]> Co-authored-by: Daniel King <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
mvpatel2000
added a commit
that referenced
this pull request
Jul 21, 2024
* fold ema fsdp state * debug * debug * more debug * keep debugging * debug * sanity check * debug * debug * use ema * debug * debug * debug * debug * debug * debug * more fix * filename test * revert test * fully parameterize * hsdp test * revert testing * typo * typo * hsdp * split off test * precommit * float to int * pyright * oom * print * rm tp * tp cfg * tp? * rm tp line * type annotation * revert * readd tp * type * world size * revert * revert monolithic cpkt + include sharded cpkt * enumerate * precommit * precommit * sharded * sync * only sync on first trainer * typo * hsdp * xfail * explicit sync * test * revert test * sync, docker issue * pre-commit * sync * pytest * xfail * rm world_size param * im so sorry pls forgive me king * the kings comments * Update tests/trainer/test_fsdp_checkpoint.py fix formatting Co-authored-by: Mihir Patel <[email protected]> * precommit --------- Co-authored-by: v-chen_data <[email protected]> Co-authored-by: Daniel King <[email protected]> Co-authored-by: Mihir Patel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is meant to add HSDP and MoE CI tests to composer using 4GPUs.
What issue(s) does this change relate to?
Before submitting
pre-commiton your change? (see thepre-commitsection of prerequisites)