Switch mosaicml logger to use futures to enable better error handling #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j316chuck
changed the title
siriuslee
reviewed
Nov 8, 2023
dakinggg
reviewed
Nov 8, 2023
dakinggg
reviewed
Nov 9, 2023
j316chuck
force-pushed
the
chuck/protected
branch
from
7635d28 to
f4700a2
Compare
dakinggg
approved these changes
Nov 14, 2023
Skylion007
reviewed
Nov 14, 2023
Skylion007
reviewed
Nov 14, 2023
Co-authored-by: Aaron Gokaslan <[email protected]>
mvpatel2000
reviewed
Nov 14, 2023
mvpatel2000
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
@j316chuck can we run one final manual test because we've changed a lot
Co-authored-by: Mihir Patel <[email protected]>
|
test run name: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switch mosaicml logger to use futures to enable better error handling.
Helps close out this PR from Tyler.
What issue(s) does this change relate to?
Tests that if mcli retries fail (currently it'll retry 10x with an exponentail backoff), then the run fails.
Tests
Added unit tests