Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no eval_loader when eval is disabled #2657

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Allow no eval_loader when eval is disabled #2657

merged 1 commit into from
Oct 19, 2023

Conversation

b-chu
Copy link
Contributor

@b-chu b-chu commented Oct 19, 2023

What does this PR do?

Allows no eval_loader to be specified when eval_interval=0 which means eval is disabled

What issue(s) does this change relate to?

GRT-2442

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@b-chu b-chu requested a review from mvpatel2000 October 19, 2023 04:03
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great QoL improvement

@b-chu b-chu merged commit 772e73e into dev Oct 19, 2023
15 checks passed
@b-chu b-chu deleted the eval_interval branch October 19, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants