-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Model Data Init and Training Progress to MosaicMLLogger #2633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
curious what @mvpatel2000 and @eracah think, but do we need a new callback for this? That is, do we actually want to log this to all logger destinations? or should we just have the MosaicMLLogger
do this?
I think it's fine to log to one or all logger destinations -- the others just won't really care since and the UX is clean on most of them. I've done one offs like this using the logger API and not had issues. I'm not sure this belongs in Composer though. The callbacks in Composer should be foundational callbacks which are broadly applicable. This feels like a callback for a bespoke use case which probably better belongs in whatever repo is leveraging it? @jjanezhang feel free to start a conversation in the composer channel if you feel it's appropriate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Had some comments and questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, awesome work! Just some nits and wanted to double check that moving to batch_end is the right call 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting sign off from me for progress logic before this lands. Can review fast whenever Jane requests :)
…nto jane/training-events
@jjanezhang will review when tests pass :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Sorry this took a bit to review
Co-authored-by: Mihir Patel <[email protected]>
Co-authored-by: Mihir Patel <[email protected]>
…nto jane/training-events
Adding Model Data Init and Training Progress to MosaicMLLogger
Testing
Started a run and confirmed that training metrics and data initialized are in run's metadata