Expose input_names and output_names when exporting to ONNX #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-mosaic
approved these changes
Oct 6, 2023
|
@antoinebrl it looks like you have some lint issues. mind fixing those and then we can merge and include this in release? |
|
@mvpatel2000 I permuted two lines to make pyright happy. |
|
@antoinebrl it looks like tests are failing. can you please take a look? |
|
I had to update some mocks used in other files. I ran the whole test suite and i can say "it works on my machine" now 😉 |
b-chu
added a commit
that referenced
this pull request
Oct 27, 2023
* Remove apex test and clean up fsdp warnings (#2616) * patch default (#2628) * Add logging for generate callbacks (#2630) * Update generate.py * add missing imports * Expose input_names and output_names when exporting to ONNX (#2601) * Expose input_names and output_names when exporting to ONNX * assert sample_input type for pyright * fix mocks --------- Co-authored-by: Mihir Patel <[email protected]> * Bump version to 0.16.4 (#2627) * bump version * filter warning * remove slack failure * composer * ckdn * commit change * commit change * commit change * commit change * rename * revert * cleanup * move around tests * log * fix slack * clean test * composer * rearrange * remove logs * skip * remove log --------- Co-authored-by: Chuck Tang <[email protected]> * many logs * typos * logs * filter * logs * fix logs * monkeypatch sharded tensor * Add partial state dict functionality for FSDP (#2637) * Use pytorch chunking commit-id:e4c9b78f * Add partial state dict functionality for FSDP commit-id:2a2cae33 * Update monai requirement from <1.3,>=0.9.1 to >=0.9.1,<1.4 (#2643) Updates the requirements on [monai](https://github.com/Project-MONAI/MONAI) to permit the latest version. - [Release notes](https://github.com/Project-MONAI/MONAI/releases) - [Changelog](https://github.com/Project-MONAI/MONAI/blob/dev/CHANGELOG.md) - [Commits](Project-MONAI/MONAI@0.9.1...1.3.0) --- updated-dependencies: - dependency-name: monai dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pytest-codeblocks from 0.16.1 to 0.17.0 (#2645) Bumps [pytest-codeblocks](https://github.com/nschloe/pytest-codeblocks) from 0.16.1 to 0.17.0. - [Release notes](https://github.com/nschloe/pytest-codeblocks/releases) - [Commits](nschloe/pytest-codeblocks@v0.16.1...v0.17.0) --- updated-dependencies: - dependency-name: pytest-codeblocks dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * remove flush on close (#2646) * update latest (#2650) * HSDP Support (#2648) * add hsdp * add tuple support * mod wide * update * set default * disable error validation * hsdp * gate import * Log profile averages (#2647) Co-authored-by: Mihir Patel <[email protected]> * bump * daily key (#2655) * Add automatic remote uploader downloader for composer profiler (#2653) * Update the AWS_OFI_NCCL version and add in the MPI HWLOC install (#2651) * Update the AWS_OFI_NCCL version and add in the MPI HWLOC install * Move the HWLOC down to the appropriate stage * Move the HWLOC to the apt-get install * Remove extra debug arg --------- Co-authored-by: Mihir Patel <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Charles Tang <[email protected]> Co-authored-by: Mihir Patel <[email protected]> Co-authored-by: Anna <[email protected]> Co-authored-by: Antoine Broyelle <[email protected]> Co-authored-by: Chuck Tang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: willgleich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It is now to configure the name of the input and output nodes of the ONNX graph.