Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log runtime estimator units #2542

Merged
merged 3 commits into from
Sep 15, 2023
Merged

Log runtime estimator units #2542

merged 3 commits into from
Sep 15, 2023

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Log runtime estimator units

aspfohl
aspfohl approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@aspfohl aspfohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

time_unit will only be 'seconds', 'minutes', 'hours', or 'days' right? Not any of the values of TimeUnit in composer core?

composer/callbacks/runtime_estimator.py Show resolved Hide resolved
dakinggg
dakinggg reviewed Sep 15, 2023
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test and manual test please

composer/callbacks/runtime_estimator.py Outdated Show resolved Hide resolved
@mvpatel2000 mvpatel2000 merged commit a1cd1fd into mosaicml:dev Sep 15, 2023
17 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/log-units branch September 15, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspfohl aspfohl aspfohl approved these changes

@eracah eracah Awaiting requested review from eracah

@dakinggg dakinggg Awaiting requested review from dakinggg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvpatel2000 @aspfohl @dakinggg