Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impr(quotes): add English quotes from Kingdom Hearts (@herfave) #6083

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

impr(quotes): add English quotes from Kingdom Hearts (@herfave) #6083

wants to merge 8 commits into from

Conversation

herfave
Copy link
Contributor

@herfave herfave commented Nov 30, 2024

Description

Add English quotes from the video game series, Kingdom Hearts

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec
Copy link
Member

Miodec commented Dec 4, 2024

Please resolve conflict

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 4, 2024
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 6, 2024
@herfave
Copy link
Contributor Author

herfave commented Dec 6, 2024

Please resolve conflict

Merge conflict resolved with 583e4a8

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 9, 2024
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@herfave herfave requested a review from Miodec December 11, 2024 22:05
@github-actions GitHub Actions
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Miodec Miodec Awaiting requested review from Miodec

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff waiting for review Pull requests that require a review before continuing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herfave @Miodec @monkeytypegeorge