Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impr(language): move british spellings to british english mode (@AnnaBuchholz) #6065

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

AnnaBuchholz
Copy link

@AnnaBuchholz AnnaBuchholz commented Nov 20, 2024

Description

I removed two words with British spelling from english_commonly_misspelled (how ironic) as well as some British spelling in English_450k.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. labels Nov 20, 2024
@AnnaBuchholz AnnaBuchholz changed the title Chore: Removed British spelling (@AnnaBuchholz) chore: removed British spelling (@AnnaBuchholz) Nov 20, 2024
@AnnaBuchholz AnnaBuchholz changed the title chore: removed British spelling (@AnnaBuchholz) impr: removed british spelling (@AnnaBuchholz) Nov 20, 2024
@Miodec
Copy link
Member

Miodec commented Nov 21, 2024

If you remove british spellings fron the word lists, please make sure to add them to the british english file to make sure they are correctly replaced.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 21, 2024
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Nov 22, 2024
@AnnaBuchholz
Copy link
Author

Alright, I believe I got them all into the British English file. Is there anything else I need to do?

Copy link
Contributor

github-actions bot commented Dec 2, 2024

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Dec 2, 2024
@github-actions github-actions bot removed the Stale Has not been updated in a while label Dec 3, 2024
@Miodec Miodec changed the title impr: removed british spelling (@AnnaBuchholz) impr(language): move british spellings to british english mode (@AnnaBuchholz) Dec 4, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Dec 4, 2024
Copy link
Contributor

This PR is stale. Please trigger a re-run of the PR check action.

@github-actions github-actions bot added the Stale Has not been updated in a while label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff Stale Has not been updated in a while waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants