GODRIVER-3086 Add ErrorCodes to ServerError API #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change Report./v2/mongocompatible changesBulkWriteException.ErrorCodes: added |
FGasper
reviewed
Nov 18, 2024
| @@ -252,9 +252,23 @@ type ServerError interface { | |||
| // HasErrorCodeWithMessage returns true if any of the contained errors have the specified code and message. | |||
| HasErrorCodeWithMessage(int, string) bool | |||
|
|
|||
| // ErrorCodes returns a deduplicated list of error codes returned by the | |||
| // server. | |||
There was a problem hiding this comment.
It’d be good to mention if there’s a defined sort order.
| return hasErrorCode(e, code) | ||
| } | ||
|
|
||
| // ErrorCodes returns a list of error codes returned by the server. |
There was a problem hiding this comment.
It’d be good to mention if there’s a defined sort order.
| } | ||
| return false | ||
|
|
||
| // Deduplicate error codes. |
There was a problem hiding this comment.
Not that it affects us :), but: I see the same logic here and in WriteException’s method. This seems like the sort of thing you’d deduplicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3086
Summary
Extend the
ServerErrorinterface to includeErrorCodeswhich will return a list of deduplicated error codes returned by the server during the lifetime of operation execution.Background & Motivation
The Go Driver provides a way to check if a ServerError has a specific error code, but no way to determine all error codes that occurred during the operation.